Improve handle sessions #6047
Merged
Improve handle sessions #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matthias-ronge
commented
Apr 22, 2024
matthias-ronge
commented
- move logout handling from version management to session management (clean-up)
- log warnings if logout fails
solth
reviewed
May 8, 2024
Kitodo/src/main/java/org/kitodo/production/security/CustomLogoutSuccessHandler.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/services/security/SessionService.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/services/security/SessionService.java
Outdated
Show resolved
Hide resolved
solth
requested changes
Aug 13, 2024
There was a problem hiding this comment.
@matthias-ronge thanks for updating the log messages. Please rebase your branch against the master and resolve the current merge conflict.
matthias-ronge
force-pushed
the
improve-handle-sessions
branch
from
10354dd to
8f57b28
Compare
matthias-ronge
force-pushed
the
improve-handle-sessions
branch
from
b428d31 to
97695a1
Compare
solth
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.