Enable edit and delete info-comments #5703
Conversation
If someone get this message as he use a non valid entry it would be very
difficult to find the right place and the causing issue. Maybe something
like that "Used not supported reimport case {}" where{} is replaced by
the wrong value can make it easier for him.
... of a class that implements an interface. Even if an object implements an interface, it's still an object and not an interface, so this naming is misleading. It fixes a bit of Javadoc as well, and eliminates an unnecessary call to the module loader every time a script is run, since the module was loaded when the class was instantiated.
…re assigned multiple times
* Add editCommentDialog.xhtml * Enable removal of Comment in CommentService and CommentsForm * Add integration test for CommentService * Changed properties of comments association in Process bean * Add edit comment messages * Update kitodo.css
* Added missing javadoc * Codacy issue
Filter client, role and project information in user list
…ents Minor design improvements
…dentifier-missing-dialog Scroll 'record identifier missing' dialog on vertical overflow
Update to version 3.6.0
|
I think you got it right, but I recorded a video just to be clear: It seems like the |
Ensure editcommentform is only rendered when edited comment is not null
|
@pontus-osterdahl would you mind rebasing your branch against the current master since there have been some fixes for the tests and builds since you first opened this pull request? |
* Add editCommentDialog.xhtml * Enable removal of Comment in CommentService and CommentsForm * Add integration test for CommentService * Changed properties of comments association in Process bean * Add edit comment messages * Update kitodo.css
* Added missing javadoc * Codacy issue
* Only allow edit/delete by author and newest comment * Corrected incorrect include
* Remove unnecessary code CommentService.java * Add Comment to ObjectType.java * Add helper method call in CommentForm.java
Ensure editcommentform is only rendered when edited comment is not null
…hub.com/pontus-osterdahl/kitodo-production into Enable-editing-and-delete-info-comments
|
@solth done. |
|
@pontus-osterdahl thank you for the update. I think something went wrong with the Github logic, though, since your pull request now lists 113 changed files with 2052 added and 474 deleted lines in those files: 
Your pull request now seems to (wrongly) list all files changed in the master since you first opened your pull request as changes of your pull request and differences between your branch and the master. The commit message of the merge commit also looks a little suspicious: 
Shouldn't this read "Merge branch 'master' of https://github.com/kitodo/kitodo-production into Enable-editing-and-delete-info-comments"? Clicking on your branch in your fork however correctly states the number of changed files and lines: 
so I guess the branch itself is in the correct state, just the pull request is somehow broken. I am not sure what went wrong here but I have a bad feeling about merging this pull request in this form. Could you open a new pull request from the branch - without any additional changes - to see if it will state the number of changes correctly? Sorry for the additional hassle! |
This pull request adds the functionality to edit and delete info-comments. Fixes #5702
Add editCommentDialog.xhtml
Enable removal of Comment in CommentService and CommentsForm
Add integration test for CommentService
Changed properties of comments association in Process bean
Add messages for editing and deleting comments
Update kitodo.css