Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return import configurations sorted by title #5644

Merged
merged 2 commits into from
May 2, 2023
Merged

Return import configurations sorted by title #5644

merged 2 commits into from
May 2, 2023

Conversation

solth
Copy link
Member

@solth solth commented Apr 28, 2023 •
edited
Loading

Currently, the entries in the pulldown menu for default import configurations in the project edit page are unsorted:

Bildschirmfoto 2023-05-02 um 10 34 49

This PR adds a small change to return import configurations sorted alphabetically from service class in order to make user experience less confusing.

@solth solth requested a review from henning-gerhardt May 2, 2023 08:17
henning-gerhardt
henning-gerhardt approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are okay and include a test. Works for me on correct page.

@solth solth merged commit 9826e41 into kitodo:master May 2, 2023
@solth solth deleted the sorted-import-configurations branch May 2, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henning-gerhardt henning-gerhardt henning-gerhardt approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solth @henning-gerhardt