Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire user session on http session timeout #5592

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

solth
Copy link
Member

@solth solth commented Mar 11, 2023

Fixes #5591

@solth solth requested a review from BartChris March 13, 2023 12:09
@BartChris
Copy link
Collaborator

BartChris commented Mar 17, 2023

I successfully tested your changes: After session expiration in browser 2 the user is no longer marked as logged in in browser 1. So the issue which appears in current master (i also checked that) is fixed. Functionality wise i approve the PR. I have no real knowledge on the session handling in general in Kitodo, so i cannot judge the changes technically.

@solth solth merged commit a19ecb9 into kitodo:master Mar 20, 2023
@solth solth deleted the session-expiration branch March 20, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"logged in" status in user list not updated on session expiration
2 participants