Add 'strict' mode to let metadata validation fail on warnings #5510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henning-gerhardt
approved these changes
Jan 23, 2023
solth
force-pushed
the
fail-on-warning
branch
from
392c9df to
e29ab26
Compare
solth
force-pushed
the
fail-on-warning
branch
from
e29ab26 to
0d5dfe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are based on adjustments made by @henning-gerhardt to allow validation to fail not just on
ERRORs, but also onWARNINGs. It also adds a new boolean parametervalidationFailOnWarningto the filekitodo_config.propertiesto make this behaviour configurable, thus introducing astrictvalidation made.