Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE in the last 'processesTable' page if all rows are selected #5506

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Fix NPE in the last 'processesTable' page if all rows are selected #5506

merged 2 commits into from
Feb 20, 2023

Conversation

IkramMaalej
Copy link
Collaborator

fixes #5266

@IkramMaalej IkramMaalej force-pushed the NPE-select-all-processes branch from 3c109c1 to a733e89 Compare January 17, 2023 14:24
andre-hohmann
andre-hohmann approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@andre-hohmann andre-hohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the skipping of result pages of several result lists and could not enforce the NPE.

Therefore, from the users' perspective, the issue could be closed with this PR.

henning-gerhardt
henning-gerhardt approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good and valid.

@IkramMaalej IkramMaalej force-pushed the NPE-select-all-processes branch from c40d887 to 2e73e6e Compare February 20, 2023 09:13
@solth solth merged commit 01c41b4 into kitodo:master Feb 20, 2023
@IkramMaalej IkramMaalej deleted the NPE-select-all-processes branch February 20, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre-hohmann andre-hohmann andre-hohmann approved these changes

@henning-gerhardt henning-gerhardt henning-gerhardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function "Select all rows" leads to exception
4 participants
@IkramMaalej @henning-gerhardt @andre-hohmann @solth