Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Fixes an issue in that our dSYMs were silently failing to upload to Fabric/Crashlytics.
🤔 Why
tl;dr - We enjoy de-symbolicating stuff.
iOS crash logs only show symbols (memory addresses) in their stack traces unless these files are provided which allows Fabric to de-symbolicate them so that they are legible to mere mortals such as us.
🛠 How
Updated:
2.126.0
.1.6.0
(it kept warning about this).3.13.2
.upload-symbols
binary which appears to be where the change crept in. We keep this binary in ourbin
directory and it appears that the newer version of this handles an API change which was causing ours to break. An added benefit is that this file is significantly smaller than the previous binary 🤷♂References:
fastlane/fastlane#14140
fastlane/fastlane#13096
https://docs.fastlane.tools/actions/upload_symbols_to_crashlytics/ (
binary_path
).👀 See
✅ Acceptance criteria
Shell command exited with exit status 8 instead of 0.
error (see steps below).You can test this locally by doing the follow:
^ Find the API KEY here: https://fabric.io/settings/organizations/ (select the production app, API key at the top).