[NT-1704] Update ReactiveSwift to 6.5.0 #1351
Conversation
Cartfile
Outdated
| @@ -1,15 +1,15 @@ | |||
| ### Internal | |||
|
|
|||
| github "kickstarter/Kickstarter-Prelude" "9118beee2b37fa5fc5a4f56502c1fa99030b9f9e" | |||
| github "kickstarter/Kickstarter-ReactiveExtensions" "48a3f507995a6bdae964ddf9f2347af6bf74a19f" | |||
| github "kickstarter/Kickstarter-ReactiveExtensions" "807153fe7e2cdb9ebcdc46862458e9e2c6b70d94" | |||
There was a problem hiding this comment.
This SHA will be updated once kickstarter/Kickstarter-ReactiveExtensions#82 merges.
| # For Xcode 12 make sure EXCLUDED_ARCHS is set to arm architectures otherwise | ||
| # the build will fail on lipo due to duplicate architectures. | ||
| # Xcode 12 Beta 3: |
There was a problem hiding this comment.
These were no longer needed for the workaround and caused Alamofire to fail to build.
justinswart
added
blocked
|
@singhhari blocking this until #1352 merges - it appears that iOS 14.2 may require us to re-record all of our snapshots 🤦♂️ |
| .on { _ in | ||
| AppEnvironment.current.userDefaults.hasDismissedPersonalizationCard = true | ||
| } | ||
| .on(value: { _ in AppEnvironment.current.userDefaults.hasDismissedPersonalizationCard = true }) |
There was a problem hiding this comment.
Interesting. The update to 6.5 wants the value param explicitly written now?
There was a problem hiding this comment.
It works without it but complains about ambiguity.
justinswart
added
blocked
Codecov Report
@@ Coverage Diff @@
## master #1351 +/- ##
==========================================
- Coverage 86.04% 86.04% -0.01%
==========================================
Files 1100 1100
Lines 97641 97640 -1
==========================================
- Hits 84013 84012 -1
Misses 13628 13628
Continue to review full report at Codecov.
|
* Updating AppCenter to 4.0.0. * Updating Optimizely to 3.6.1. * Updating Facebook iOS SDK to 8.2.0. * Use 6.5.2 for FBSDK and 7.3.0 for Firebase Co-authored-by: Justin Swart <justinswart@users.noreply.github.com>
📲 What
Updates ReactiveSwift to
6.5.0.Note: kickstarter/Kickstarter-ReactiveExtensions#82 should merge before this.
🤔 Why
There have been a number of improvements to this framework that we use throughout our codebase (see release notes below).
🛠 How
Cartfile.filterMapwithcompactMap.👀 See
ReactiveSwift release notes
Carthage workaround
✅ Acceptance criteria