Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Logging Middleware for v0.4 #2063

Merged
merged 2 commits into from
Jan 7, 2016

Conversation

gmmeyer
Copy link
Contributor

@gmmeyer gmmeyer commented Jan 6, 2016

I would love to have the ability to define my own custom logging middleware. To be honest, I'd prefer to use Winston to Morgan, if I could.

This is a PR for v0.4 that does just this.

I allow for two different manners of defining this.

  • One is through an option on the keystone init.
  • One is through the normal middleware hook, so that people will be able to use their normal middleware workflow rather than putting it in a weird place.

@JedWatson
Copy link
Member

Looks great @gmmeyer, thanks :)

JedWatson added a commit that referenced this pull request Jan 7, 2016
Custom Logging Middleware for v0.4
@JedWatson JedWatson merged commit afc3384 into keystonejs:master Jan 7, 2016
@gmmeyer
Copy link
Contributor Author

gmmeyer commented Jan 7, 2016

:)

@ericelliott
Copy link
Contributor

Great addition. I'll be using this, myself. Thanks!

\( ゚ヮ゚)/

@webteckie
Copy link
Contributor

Docs?

@ericelliott
Copy link
Contributor

👍 for docs

@gmmeyer gmmeyer deleted the logging-0.4.x branch January 9, 2016 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants