Add margin to info text on reset password form #36428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#36427 Signed-off-by: SebastEnn <103125747+SebastEnn@users.noreply.github.com>
jonkoops
reviewed
Jan 14, 2025
| <#else> | ||
| ${msg("emailInstruction")} | ||
| </#if> | ||
| <div class="pf-v5-u-mt-md"> |
There was a problem hiding this comment.
I believe the convention is that this class should come from the properties of the theme like other classes, but I am not sure if that is the case also for classes for margins and such. @keycloak/ui WDYT?
There was a problem hiding this comment.
I also thought about that, but wasn't sure which class to use instead.
I'm looking forward for suggestions on how to add margin compliant with the convention 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36427
Signed-off-by: SebastEnn 103125747+SebastEnn@users.noreply.github.com