useResponsiveValue: Fires a side effect on dependency change #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kettanaito Hey Artem, Are you accepting pull requests on this repo? |
|
Hey, @hallaji! Thank you for preparing this. I've been busy, so I overlooked this one, my bad. |
The useResponsiveValue hook does not update the value if one of the dependencies changes. Internationalisation is a good example for this situation.
kettanaito
force-pushed
the
326-use-responsive-value-side-effect
branch
from
bd960be to
d3a439d
Compare
|
I've updated your feature branch against the latest |
kettanaito
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The useResponsiveValue hook does not update the value if one of the dependencies changes.
Internationalisation is a good example for this situation.
Changes
useResponsiveValueIssues
Release version
Contributor's checklist
masteryarn verifyto see the build and tests pass