Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KerasCV and KerasNLP; new structure for KerasHub and KerasTuner #1993

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

mattdangerw
Copy link
Member

  • Remove all KerasCV and KerasNLP docs.
  • Add redirects so that KerasCV and KerasNLP links point to KerasHub.
  • Rework the URL structure so that all KerasHub and KerasTuner content is nested inside the toplevel on the sidebar.
    • guides/keras_hub/xx -> keras_hub/guides/xx.
    • api/keras_hub/xx -> keras_hub/api/xx.

Screenshot from 2024-11-25 10-16-58

@mattdangerw
Copy link
Member Author

Not all KerasCV guides have a KerasHub replacement yet. These guides no longer show up on the site, but I've left them in the repo so they can be ported.

@divyashreepathihalli
Copy link
Contributor

would https://keras.io/keras_cv/ take to keras_cv page or the keras_hub page?

@mattdangerw
Copy link
Member Author

@divyashreepathihalli KerasCV page will be gone! keras.io/keras_cv will redirect to keras.io/keras_hub

You might want to try rendering locally to get a sense of the new structure.

@divyashreepathihalli
Copy link
Contributor

@divyashreepathihalli KerasCV page will be gone! keras.io/keras_cv will redirect to keras.io/keras_hub

You might want to try rendering locally to get a sense of the new structure.

I will check it out!

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks great.

The redirects need to be more granular, especially for KerasCV -- anytime there's a relevant page we can point to, we should. Examples:

  • /api/keras_cv/layers/augmentation/* - > /api/layers/preprocessing_layers/image_augmentation/
  • /api/keras_cv/models/backbones/efficientnet_v2/ -> corresponding API page in KerasHub
  • /api/keras_cv/models/tasks/stable_diffusion/ -> corresponding API page in KerasHub (note, this one has quite a few links that point to it!)
  • etc.

Please go over each one by hand and determine what the best page to redirect to is.

@mattdangerw
Copy link
Member Author

Thanks! Yeah, that is done for KerasTuner/KerasHub/KerasNLP since there's a one-to-one correspondence. But yeah KerasCV will need a more careful touch. Will do!

@mattdangerw
Copy link
Member Author

@fchollet improved the CV links a bit, though a good bit doesn't have a perfect replacement. E.g. for bounding boxes and preprocessing layers in CV I'm just linking to core Keras preprocessing layers.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it

@fchollet fchollet merged commit 05faae3 into keras-team:master Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants