Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [UTG] flaky flag and prioritize coverage check over flaky check #2445

Merged
merged 3 commits into from
Nov 21, 2024
Merged

feat: [UTG] flaky flag and prioritize coverage check over flaky check #2445

merged 3 commits into from
Nov 21, 2024

Conversation

khareyash05
Copy link
Contributor

@khareyash05 khareyash05 commented Nov 21, 2024 •
edited
Loading

Adds a flaky flag

  1. If test fails, return with no coverage and no more flaky check,
  2. If test pass and coverage increases, check flakiness flag, 5 iteration to check flakiness

@khareyash05
feat: flaky flag and prioritize coverage check over flaky check
605832f 
Signed-off-by: Yash Khare <khareyash05@gmail.com>
@khareyash05 khareyash05 changed the title feat: flaky flag and prioritize coverage check over flaky check feat: [UTG] flaky flag and prioritize coverage check over flaky check Nov 21, 2024
@khareyash05
gofmted
aa2465d 
Signed-off-by: Yash Khare <khareyash05@gmail.com>
@khareyash05
better logging messages
124fc8a 
Signed-off-by: Yash Khare <khareyash05@gmail.com>
@khareyash05 khareyash05 self-assigned this Nov 21, 2024
Sarthak160
Sarthak160 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Sarthak160 Sarthak160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khareyash05 khareyash05 merged commit bc58c69 into main Nov 21, 2024
17 of 18 checks passed
@khareyash05 khareyash05 deleted the flaky-flag branch November 21, 2024 17:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sarthak160 Sarthak160 Sarthak160 approved these changes

Assignees

@khareyash05 khareyash05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khareyash05 @Sarthak160