Add find primitive root #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To find primitive root, Euler's totient function is used. |
keon
reviewed
Dec 6, 2019
| 0 is the only primitive root of 1 """ | ||
| else: | ||
| phi = euler_totient(n) | ||
| pRootList = [] |
There was a problem hiding this comment.
please use consistent naming convention
There was a problem hiding this comment.
[Edit] Change pRootList into p_root_list
keon
reviewed
Dec 6, 2019
PULL_REQUEST_TEMPLATE.md
Outdated
| - [X] **If creating a new file :** | ||
| - [X] added links to it in the README files ? | ||
| - [X] included tests with it ? | ||
| - [X] added description (overview of algorithm, time and space complexity, and possible edge case) in docstrings ? |
There was a problem hiding this comment.
[Edit] Revert PULL_REQUEST_TEMPLATE.md
…solving collision
…find_primitive_root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Put an
Xinside the[ ]to denote check mark[X].)If creating a new file :
if done some changes :
other