Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add find order #605

Merged
merged 18 commits into from
Dec 9, 2019
Merged

Add find order #605

merged 18 commits into from
Dec 9, 2019

Conversation

D-Sinus
Copy link
Contributor

@D-Sinus D-Sinus commented Dec 5, 2019 •
edited
Loading

(Put an X inside the [ ] to denote check mark [X].)

  • If creating a new file :

    • added links to it in the README files ?
    • included tests with it ?
    • added description (overview of algorithm, time and space complexity, and possible edge case) in docstrings ?

  • if done some changes :

    • wrote short description in the PR explaining what the changes do ?
    • Fixes #[issue number] if related to any issue

  • other

D-Sinus added 15 commits December 2, 2019 19:28
@D-Sinus
[Add] Find order algorithm and its supplemental
ca3f441
@D-Sinus
[Add] Find primitive root algorithm
d323b30
@D-Sinus
[Edit] Add 'find_' in front of primitive root algorithm file
de67fd4
@D-Sinus
[Add/Fix] Supplemental & exception handling for the case n = 1
ac8a395
@D-Sinus
[Fix] Exception handling for the case a == n == 1 in findOrder function
5e699ba
@D-Sinus
[Delete] Left find_order algorithm only in this branch
e25c633
@D-Sinus
[Add] Link to find_order algorithm in the README.md
c2eec54
@D-Sinus
[Add] Test cases for find_order_simple.py
7318e87
@D-Sinus
[Edit] Modify pull request template
285e018
@D-Sinus
[Edit] Exclude mistyped one space in README.md
1f46c9c
@D-Sinus
[Fix] Problems in test
b31a648
@D-Sinus
[Edit] Function name in algorithm file and test file
7e9992d
@D-Sinus
[Edit] Function name in unittest file
02c6dc8
@D-Sinus
[Edit] Function name in unittest file (2)
f8232fa
@D-Sinus
[Edit] Add module information into __init__.py
f5e8f11
@D-Sinus
Copy link
Contributor Author

D-Sinus commented Dec 5, 2019 •
edited
Loading

I implemented algorithm that finds multiplicative order for given numbers.
If there's any problems in my code, please let me know.
Thanks.

Ps. Cuz I'm not familiar with unittest, I've done some unnecessary commits. Sorry for that.

keon
keon reviewed Dec 6, 2019
View reviewed changes
PULL_REQUEST_TEMPLATE.md Outdated
- [X] **If creating a new file :**
- [X] added links to it in the README files ?
- [X] included tests with it ?
- [X] added description (overview of algorithm, time and space complexity, and possible edge case) in docstrings ?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to edit template

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.
First, thanks for your feedback.
I have question about 'edit template', did you mean that I have to erase that X mark
and leave PULL_REQUEST_TEMPLATE.md as same as original file?
I can reply in 3 mintues. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Edit] Revert PULL_REQUEST_TEMPLATE.md

@keon keon merged commit 55877e7 into keon:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keon keon keon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D-Sinus @keon