Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update limit.py #502

Merged
merged 2 commits into from
May 17, 2019
Merged

Update limit.py #502

merged 2 commits into from
May 17, 2019

Conversation

songzhi
Copy link
Contributor

@songzhi songzhi commented May 16, 2019

  • If creating a new file :

    • added links to it in the README files ?
    • included tests with it ?
    • added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?

  • if done some changes :

    • wrote short description in the PR explaining what the changes do ?
    • Fixes #[issue number] if related to any issue

  • other

More Pythonic in my view

@coveralls
Copy link

coveralls commented May 16, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 906

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 75.629%
Changes Missing Coverage Covered Lines Changed/Added Lines %
algorithms/arrays/limit.py 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
algorithms/linkedlist/is_palindrome.py 1 93.33%
Totals Coverage Status
Change from base Build 904: -0.02%
Covered Lines: 5980
Relevant Lines: 7907
💛 - Coveralls

@songzhi songzhi closed this May 17, 2019
@songzhi songzhi reopened this May 17, 2019
@keon keon merged commit 95ad7b2 into keon:master May 17, 2019
@keon
Copy link
Owner

keon commented May 17, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@songzhi @coveralls @keon