Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix badge #288

Merged
merged 2 commits into from
Feb 1, 2023
Merged

chore: fix badge #288

merged 2 commits into from
Feb 1, 2023

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Feb 1, 2023

No description provided.

README.md Outdated
[package_version_badge]: https://img.shields.io/npm/v/sort-package-json.svg
[package_link]: https://www.npmjs.com/package/sort-package-json
[github_actions_badge]: https://img.shields.io/github/actions/workflow/status/keithamus/sort-package-json/pr.yml
[github_actions_link]: https://github.com/keithamus/sort-package-json/actions?query=workflow%3ACI+branch%3Amaster
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keithamus Since I'm working on this, do you think it's a good opportunity to rename master to main? Unless you don't want to.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, 4270583.

Also made some changes to CI config.

I don't have access to rename branch, you'll have to do it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed to main 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@fisker fisker marked this pull request as ready for review February 1, 2023 12:26
@keithamus keithamus merged commit da38e3d into keithamus:main Feb 1, 2023
@fisker fisker deleted the badge branch February 1, 2023 12:35
@fisker
Copy link
Collaborator Author

fisker commented Feb 1, 2023

@fisker fisker mentioned this pull request Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

🎉 This PR is included in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants