Added contributors to about dialog #629
Conversation
src/gui/AboutDialog.ui
Outdated
| <p style=" margin-top:16px; margin-bottom:12px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;"><span style=" font-size:x-large; font-weight:600;">Code:</span></p> | ||
| <ul style="margin-top: 0px; margin-bottom: 0px; margin-left: 0px; margin-right: 0px; -qt-list-indent: 1;"><li style=" font-size:10pt;" style=" margin-top:12px; margin-bottom:2px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">debfx (KeePassX)</li> | ||
| <li style=" font-size:10pt;" style=" margin-top:0px; margin-bottom:2px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">BlueIce (KeePassX)</li> | ||
| <li style=" font-size:10pt;" style=" margin-top:0px; margin-bottom:2px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;">droidmonkey</li> |
There was a problem hiding this comment.
Are you sure, setting a specific font size is a good idea?
There was a problem hiding this comment.
No im not sure, but the default size (8pt) is so ugly and small in comparison. What's the best practice? I assume a style sheet.
There was a problem hiding this comment.
A stylesheet is actually very bad practice. The problem is that 8pt is always 8pt, so it may be extremely ugly if you have a different default font size and it will be unresponsive to any font size changes you make on your system. That means it's also not very friendly towards people who configured a rather large font size, because they are having trouble reading text at smaller sizes. Unfortunately, font sizes relative to the default font size are only possible programmatically in C++ (as we have done it for the password generator).
I noticed, too, that the default font size on Windows is generally tiny. KDE has a much better default font size.
There was a problem hiding this comment.
The only thing we could do is changing the font size in C++ as we have done for the password generator.
There was a problem hiding this comment.
@phoerious your thought on this? If it's good we can merge
There was a problem hiding this comment.
So you left it in the read-only text field? I guess should at least remove the font-family property.
There was a problem hiding this comment.
For what its worth I stumbled on a QtCreator bug while doing this PR... the Windows version adds a bunch of font family and size attributes to everything without prompting. Something to look out for in the future.
There was a problem hiding this comment.
Yah, that's why I edited the HTML manually to keep it as clean as possible.
There was a problem hiding this comment.
OK I made the changes requested.
There was a problem hiding this comment.
Looks good! Would be nice to have the lists generated programmatically at some point though. For example from a Contributors.txt file in the repo that would be loaded and used to add all the list items to the dialog. We could then update this file automatically for every new release.
|
I thought of that but the amount of code required and distribution made this way so much easier, especially since this does not change often. I don't think there is an automated way to handle this. |
droidmonkey
force-pushed
the
feature/contributors
branch
from
f6ca8ab to
01ae1b8
Compare
|
@droidmonkey can you rebase this and merge into 2.2.0 ? |
|
@droidmonkey The font looks quite small on OSX:
|
droidmonkey
force-pushed
the
feature/contributors
branch
from
01ae1b8 to
97c8603
Compare
|
@weslly the root problem is that all platforms have different default font sizes, and Qt does not support relative font sizes (e.g., em's). We either have to create a default style-sheet per platform or accept these sorts of errors. |
|
Wow, that looks ugly. Maybe we could just not style it at all or maybe apply styling programmatically? |
|
I'll investigate this in 2.2.1 |
- Added YubiKey 2FA integration for unlocking databases [#127] - Added TOTP support [#519] - Added CSV import tool [#146, #490] - Added KeePassXC CLI tool [#254] - Added diceware password generator [#373] - Added support for entry references [#370, #378] - Added support for Twofish encryption [#167] - Enabled DEP and ASLR for in-memory protection [#371] - Enabled single instance mode [#510] - Enabled portable mode [#645] - Enabled database lock on screensaver and session lock [#545] - Redesigned welcome screen with common features and recent databases [#292] - Multiple updates to search behavior [#168, #213, #374, #471, #603, #654] - Added auto-type fields {CLEARFIELD}, {SPACE}, {{}, {}} [#267, #427, #480] - Fixed auto-type errors on Linux [#550] - Prompt user prior to executing a cmd:// URL [#235] - Entry attributes can be protected (hidden) [#220] - Added extended ascii to password generator [#538] - Added new database icon to toolbar [#289] - Added context menu entry to empty recycle bin in databases [#520] - Added "apply" button to entry and group edit windows [#624] - Added macOS tray icon and enabled minimize on close [#583] - Fixed issues with unclean shutdowns [#170, #580] - Changed keyboard shortcut to create new database to CTRL+SHIFT+N [#515] - Compare window title to entry URLs [#556] - Implemented inline error messages [#162] - Ignore group expansion and other minor changes when making database "dirty" [#464] - Updated license and copyright information on souce files [#632] - Added contributors list to about dialog [#629]
Description
Adds a contributors tab to the about dialog that is populated with the top code contributors and translators. Also did some cleanup of the about dialog itself. Implements #376.
How has this been tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]