Expected Behavior

KeeAgent.settings should only be added to an entry when there are settings to store, as in a key is set up to be used.

Current Behavior

KeeAgent.settings are added to an entry on some occasions.

Possible Solution

Don't add KeeAgent.settings if it does not exist and the key is not set up (i.e. chosen attachment or path are empty).

Steps to Reproduce

1. Enable SSH Agent
2. Restart the program
3. Create a new entry and add an attachment.
   • Also works when editing an existing entry.
4. Save it by pressing Ok.
5. Notice that KeeAgent.settings is present but not required

Context

The impact of this issue is minor at best. I noticed it when I opened my database on my phone and looked at an entry where I added an attachment.
The ~1.4 KB the file adds to the entry is not large but it could add up for a larger database and could become noticeable when syncing it on a mobile client.

Debug Info

KeePassXC - 2.5.1
Revision: 0fd8836

Libraries:

• libgcrypt 1.8.5

Operating system: Windows 10 (10.0)
CPU architecture: x86_64
Kernel: winnt 10.0.18362

Enabled extensions:

• Auto-Type
• Browser Integration
• SSH Agent
• KeeShare (signed and unsigned sharing)
• YubiKey