Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google analytics: make it work for our GA4 property #661

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Google analytics: make it work for our GA4 property #661

merged 2 commits into from
Feb 18, 2022

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 17, 2022 •
edited
Loading

  • Contributes to Use Google Analytics to better understand end-users #594
  • This is take 2 to get the GA4 property to work using the current version of Hugo (v0.67.0).
    If this doesn't work, we'll either need to upgrade Hugo (preferred) or use a custom template.
  • Also, added template code so that only the production build gets tracked.

/cc @nate-double-u

@netlify
Copy link

netlify bot commented Feb 17, 2022 •
edited
Loading

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: a0ed5d9

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/620e9fec61d2120007df2913

😎 Browse the preview: https://deploy-preview-661--keda.netlify.app

@chalin chalin mentioned this pull request Feb 17, 2022
Open
@chalin
Google analytics: make it work for our GA4 property
1d7088d 
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin chalin force-pushed the chalin-ga-take2-2022-02-17 branch from 19364a0 to 1d7088d Compare February 17, 2022 19:16
@chalin
Disable analytics for prevew builds (now that we know it works)
a0ed5d9 
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
@chalin chalin force-pushed the chalin-ga-take2-2022-02-17 branch from e123fcd to a0ed5d9 Compare February 17, 2022 19:20
@tomkerkhove tomkerkhove merged commit 3609250 into kedacore:main Feb 18, 2022
@chalin chalin deleted the chalin-ga-take2-2022-02-17 branch February 18, 2022 11:47
@chalin
Copy link
Contributor Author

chalin commented Feb 18, 2022

This change wasn't enough to get GA to work. Next step is #662.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@jeffhollan jeffhollan Awaiting requested review from jeffhollan

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @tomkerkhove