Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: No longer push to Docker Hub on release #2562

Merged
merged 4 commits into from
Jan 28, 2022
Merged

chore: No longer push to Docker Hub on release #2562

merged 4 commits into from
Jan 28, 2022

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented Jan 26, 2022

On June 21, 2021, GitHub Container Registry became generally available which means that we will no longer push to Docker Hub on release as per kedacore/governance#16 and our announcement in March 2021.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Changelog has been updated

Fixes kedacore/governance#16

No longer push to Docker Hub on release as per kedacore/governance#16

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
No longer push to Docker Hub on release as per kedacore/governance#16

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
No longer push to Docker Hub on release as per kedacore/governance#16

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
No longer push to Docker Hub on release as per kedacore/governance#16

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove requested a review from a team as a code owner January 26, 2022 14:34
@tomkerkhove
Copy link
Member Author

tomkerkhove commented Jan 26, 2022

/run-e2e *

Update: You can check the progres here

@tomkerkhove
Copy link
Member Author

@JorTurFer How do I run all e2e tests again?

@JorTurFer
Copy link
Member

JorTurFer commented Jan 26, 2022

@JorTurFer How do I run all e2e tests again?

They are already running @tomkerkhove. You can trigger them again posting the command again, but you should wait till current execution ends (because it finishes or you cancel it)

image

@tomkerkhove
Copy link
Member Author

tomkerkhove commented Jan 27, 2022

/run-e2e *
Update: You can check the progres here

@tomkerkhove
Copy link
Member Author

@JorTurFer All jobs are successful in the e2e run but it reports failure. Do you know why?
https://github.com/kedacore/keda/runs/4962487591?check_suite_focus=true

Is it related to the run duration?

@zroubalik zroubalik added this to the v2.6.0 milestone Jan 28, 2022
@zroubalik zroubalik merged commit a164a47 into main Jan 28, 2022
@zroubalik zroubalik deleted the docker-hub branch January 28, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating our containers to GitHub Container Registry
3 participants