Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest highctidh #489

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Use latest highctidh #489

merged 2 commits into from
Jan 11, 2024

Conversation

david415
Copy link
Member

@david415 david415 commented Jan 11, 2024

if all tests pass then please merge me

@ioerror ioerror self-requested a review January 11, 2024 21:57
@david415 david415 self-assigned this Jan 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a37a45f) 47.65% compared to head (bf8c0c9) 47.77%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   47.65%   47.77%   +0.11%     
==========================================
  Files          86       86              
  Lines       15011    15011              
==========================================
+ Hits         7153     7171      +18     
+ Misses       6905     6889      -16     
+ Partials      953      951       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ioerror ioerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally the next improvement should be to test and use each highctidh field size.

@ioerror ioerror merged commit e484d47 into main Jan 11, 2024
10 checks passed
@ioerror ioerror deleted the use_latest_highctidh branch January 11, 2024 22:32
@katzenpost katzenpost deleted a comment Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants