Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Ratelimit module #34

Merged
merged 7 commits into from
Aug 28, 2024
Merged

Add the Ratelimit module #34

merged 7 commits into from
Aug 28, 2024

Conversation

junr03
Copy link
Collaborator

@junr03 junr03 commented Aug 7, 2024

This PR adds a Ratelimit module that manages a singleton Ratelimit data structure that will be used in subsequent changes to enable Token-based Ratelimiting.

related to #37

junr03 added 7 commits August 6, 2024 11:05
Signed-off-by: José Ulises Niño Rivera <junr03@users.noreply.github.com>
Signed-off-by: José Ulises Niño Rivera <junr03@users.noreply.github.com>
Signed-off-by: José Ulises Niño Rivera <junr03@users.noreply.github.com>
Signed-off-by: José Ulises Niño Rivera <junr03@users.noreply.github.com>
Signed-off-by: José Ulises Niño Rivera <junr03@users.noreply.github.com>
Signed-off-by: José Ulises Niño Rivera <junr03@users.noreply.github.com>
Copy link
Contributor

@adilhafeez adilhafeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for writing those test cases, they seem to have good coverage

@junr03
Copy link
Collaborator Author

junr03 commented Aug 27, 2024

@adilhafeez, any more comments or is this ready to land?

@adilhafeez adilhafeez self-requested a review August 28, 2024 05:25
@junr03 junr03 merged commit 4dd1f36 into main Aug 28, 2024
3 checks passed
@junr03 junr03 deleted the process-ratelimit-config branch September 5, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants