Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rebalancer auto deleted failed #5989

Merged
merged 1 commit into from
Dec 30, 2024
Merged

fix rebalancer auto deleted failed #5989

merged 1 commit into from
Dec 30, 2024
+9 −6

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Dec 28, 2024 •
edited by RainbowMango
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix rebalancer auto deleted failed

Which issue(s) this PR fixes:

Fixes #5985

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`karmada-controller-manager`: Fixed the bug of WorkloadRebalancer doesn't get deleted after TTL.

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 28, 2024
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 28, 2024
@chaosi-zju chaosi-zju mentioned this pull request Dec 28, 2024
Closed
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.25%. Comparing base (337c27b) to head (5b7df5b).

Files with missing lines Patch % Lines
...orkloadrebalancer/workloadrebalancer_controller.go 0.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5989      +/-   ##
==========================================
+ Coverage   48.24%   48.25%   +0.01%     
==========================================
  Files         665      665              
  Lines       54797    54795       -2     
==========================================
+ Hits        26435    26440       +5     
+ Misses      26645    26639       -6     
+ Partials     1717     1716       -1
Flag Coverage Δ
unittests 48.25% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango RainbowMango added this to the v1.13 milestone Dec 28, 2024
RainbowMango
RainbowMango reviewed Dec 28, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

@karmada-bot karmada-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2024
@chaosi-zju
fix rebalancer auto deleted failed
5b7df5b 
Signed-off-by: chaosi-zju <chaosi@zju.edu.cn>
RainbowMango
RainbowMango approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2024
@karmada-bot karmada-bot merged commit cf5def1 into karmada-io:master Dec 30, 2024
21 checks passed
@RainbowMango RainbowMango mentioned this pull request Dec 30, 2024
Closed
3 tasks
This was referenced Dec 30, 2024
Merged
Merged
Merged
karmada-bot added a commit that referenced this pull request Dec 30, 2024
@karmada-bot
Merge pull request #5993 from deefreak/automated-cherry-pick-of-#5989…
151d882 
…-upstream-release-1.10

Automated cherry pick of #5989: fix rebalancer auto deleted failed
karmada-bot added a commit that referenced this pull request Dec 30, 2024
@karmada-bot
Merge pull request #5994 from deefreak/automated-cherry-pick-of-#5989…
c087cfe 
…-upstream-release-1.11

Automated cherry pick of #5989: fix rebalancer auto deleted failed
karmada-bot added a commit that referenced this pull request Dec 30, 2024
@karmada-bot
Merge pull request #5995 from deefreak/automated-cherry-pick-of-#5989…
3e154f7 
…-upstream-release-1.12

Automated cherry pick of #5989: fix rebalancer auto deleted failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RainbowMango RainbowMango RainbowMango approved these changes

@Garrybest Garrybest Awaiting requested review from Garrybest

@Vacant2333 Vacant2333 Awaiting requested review from Vacant2333

Assignees

@RainbowMango RainbowMango

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

WorkloadRebalancer doesn't get deleted after TTL.
4 participants
@chaosi-zju @codecov-commenter @karmada-bot @RainbowMango