[Umbrella] standardize the naming of karmada secrets across different installation methods #5363
Description
What would you like to be added:
standardize the naming of karmada secrets across different installation methods.
Why is this needed:
In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert
, which contains a series of cert files like ca.crt
, apiserver.crt
and so on; another is karmada-kubeconfig
, which contains a kubeconfig of karmada-apiserver.
However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, such as:
- As for
secert/karmada-cert
, is namedkarmada-cert-secret
inlocal up
method, while namedkarmada-cert
inkarmadactl
method, which potentially caused: - In
secert/karmada-cert
, ca cert file is namedca.crt
inlocal up
method, while namedserver-ca.crt
inhelm
method, which potentially caused: - As for
secert/karmada-kubeconfig
, is namedkubeconfig
inkarmadactl init
andlocal up
method, while namedkarmada-kubeconfig
inhelm
method. - In
helm
method, if I install karmada byhelm install karmada-xxx ...
, it will create a secret namingkarmada-xxx-cert
. Then if I install the singlekarmada-scheduler-estimator
component byhelm install karmada-scheduler-estimator-xxx --set installMode=component ...
, the component will look for secret namingkarmada-scheduler-estimator-xxx-cert
, the name is inconsistent. In this case, since we cannot reuse the same.Release.Name
when executing helm install, the secret name is not advised to be prefixed with.Release.Name
.
How to do
I advise to standardize the naming of these karmada secrets like below in all installation methods:
-
secretName: client-cert
mountPath: /etc/karmada/pki/client (tls.crt、tls.key、ca.crt) -
secretName: server-cert
mountPath: /etc/karmada/pki/server (tls.crt、tls.key、ca.crt) -
secretName: front-proxy-client-cert
mountPath: /etc/karmada/pki/front-proxy-client (tls.crt、tls.key、ca.crt) -
secretName: etcd-client-cert
mountPath: /etc/karmada/pki/etcd-client (tls.crt、tls.key、ca.crt) -
secretName: etcd-server-cert
mountPath: /etc/karmada/pki/etcd-server (tls.crt、tls.key、ca.crt) -
secretName: webhook-server-cert
mountPath: /etc/karmada/pki/webhook-server (tls.crt、tls.key、ca.crt) -
secretName: ca-key-pair
mountPath: /etc/karmada/pki/ca (tls.crt、tls.key) -
secretName: karmada-config
mountPath: /etc/karmada/config/karmada.config
Activities
-
- local up method: standardize the naming of karmada secrets in local up method #5423
-
- karmadactl method: standardize the naming of karmada secrets in karmadactl method #5524
-
- karmada operator method: standardize the naming of karmada secrets in operator method #5573
Metadata
Assignees
Type
Projects
Status
No status