refactor(launcher): Update launcher to ES6 #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnjbarton
suggested changes
May 24, 2018
lib/launcher.js
Outdated
| return !browser.isCaptured() | ||
| }) | ||
| this.areAllCaptured = () => { | ||
| return this._browsers.every((browser) => browser.isCaptured()) |
There was a problem hiding this comment.
Can we use an expression return:
() => this._browsers.every((browser) => browser.isCaptured())
?
lib/launcher.js
Outdated
| } | ||
| } | ||
|
|
||
| this.launch = function (names, concurrency) { | ||
| this.launch = (names, concurrency) => { | ||
| lastStartTime = Date.now() |
There was a problem hiding this comment.
To be extra careful let's put this after new Jobs as before.
devoto13
reviewed
May 24, 2018
| @@ -25,34 +26,22 @@ var baseBrowserDecoratorFactory = function ( | |||
| } | |||
| } | |||
|
|
|||
| var Launcher = function (server, emitter, injector) { | |||
| function Launcher (server, emitter, injector) { | |||
There was a problem hiding this comment.
Why not update it to be real class?
There was a problem hiding this comment.
(Actually I prefer small refactoring steps, so doing this next is my pref).
johnjbarton
approved these changes
May 24, 2018
|
This PR now conflicts with master. |
|
Conflicts with master fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within this pull request I've used a few ES6 features in
lib/launcher.jsfile to improve it's readability.