Everything passed except Node 4. Not sure what's going on here...

Retriggered, lets see what happens

I think what's going here is the build is failing because the log is too long - travis fails the build after 4mb of output - the node5 build has the same errors/warnings as the node4 build but does succeed.
I wonder if 'apt-get install build-essential' would fix this as it's complaining about a lack of c++ compiler. or cranking down the npm loglevel to slient which wouldn't be very interesting if the build failed for some other reason :)

It might have something to do with npm being not updated anymore, as otherwise this is the same as what we are currently running.

ok build-essential and g++ are already installed at their latest versions so that doesn't help. trying loglevel silent. the version of npm that comes with 4.2.1 (2.14.7) acts differently than npm with node5 (3.3.6) and latest npm (3.3.10)

I think they have to be in a new enough version if you want to compile something, the v8 used in Node>=4 can't be compiled via old gcc. Take a look at these lines in .travis.yml of node-sass.

welp got travis to pass with npm output set to silent: https://travis-ci.org/karma-runner/karma/builds/88365243
There's still a ton of output and it's still complaining about c++ (the problem is the gcc compiler is at version 199711L but NAN wants a c++ compiler at 201103L) however 199711L IS the latest version of gcc (at least on the travis VMs) so insanity ensues.
The deps it cannot install are optional but the amount of output is insane (as many others have complained about). Even with 'silent' there's still a ton of output - in fact none of that error output is supressed at all as it's not coming from npm.
thoughts?

There were the following issues with your Pull Request

• Commit: 94cb0e5
  • Your subject line is longer than 70 characters

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

@mzgol unfortunately both 4.7 and 4.8 both report themselves as 199711

There were the following issues with your Pull Request

• Commit: 754182b
  • Your subject line is longer than 70 characters

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

node-sass compiles fine on Travis on Node 5: https://travis-ci.org/sass/node-sass/jobs/88302086. I'm checking what else do we need from their config to make it work.

I'm trying to install the proper gcc/g++ versions and export proper env variables to make the commands use it but g++ --version still prints 4.6.3... I see that node-sass now declares its project language as cpp instead of node_js, I hope that's not necessary here. :O

thanks there's also this: nodejs/nan#506 (comment)
so 4.8 should work but it needs that flag. Not sure why that flag is not being supplied by gyp - i'll update that issue with more questions...

Hmm, I didn't add any flag and it compiled correctly this time: https://travis-ci.org/karma-runner/karma/jobs/88381644.

@zoo from the comment:

You need to compile with -std=c++11 for __cplusplus >= 201103 but you get that for free when you target node.js >= 4.

So my PR in its current state should be fine. :)

I wonder if the gcc upgrade is needed, maybe g++ is enough?

yes! installing 4.8 and setting 'CXX=g++-4.8' is the magic - great!

OK, I've removed some excessive variables & packages, this should still work but let's see.

OK, I've tried with g++5 but the bundles are huge (https://travis-ci.org/karma-runner/karma/jobs/88392214), ~50 MB compared to ~8 MB for 4.8 so I reverted back to 4.8. The tests passed last time so it should be fine but we can wait to be 100% sure. :)

agreed 5.0 unnecessary - 4.8 is fine thanks

Thanks guys for working through the compiler swamp :)

Haha, between my last 2 attempts a new ESLint version got released and the build now fails because of one excessive space. 👯

classic - this was as good of a time of this to happen as any tho

The following code in proxy.js is the problem:

exports.create = function (/* config */ config, /* config.proxies */ proxies) {
  return createProxyHandler(parseProxyConfig(proxies, config), config.urlRoot)
}

Sounds like a regression in ESLint to me, I reported an issue: eslint/eslint#4302.

We'll need to workaround it for now, though, I'll have to remove spaces between comments & variable names to make it pass.

Oops, I forgot to add 5 as an accepted Node version in engines. PR updated.

@zzo @dignifiedquire All tests passed. This should be ready to go. :)

spectacular lgtm

Thanks