Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐧 Disable squasfs compression for ISO building #812

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Feb 3, 2023

What this PR does / why we need it:

Space gained is negligible, just a few Kbs usually (with gzip as its currently) but the speed up improvements in building the ISO are really good, for 20 seconds to 40 seconds per ISO build, and that gets more accentuated on CI runs where the runners are more CPU constrained.

Space gained is negligible, just a few Kbs usually (with gzip as its
currently) but the speed up improvements in building the ISO are really
good, for 20 seconds to 40 seconds per ISO build, and that gets more accentuated
on CI runs where the runners are more CPU constrained.

Signed-off-by: Itxaka <itxaka@spectrocloud.com>
@Itxaka Itxaka requested a review from a team February 3, 2023 09:07
@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit 06c7a7f
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/63dcceeff7b7460008b427c7

@Itxaka
Copy link
Member Author

Itxaka commented Feb 3, 2023

No compression:

-rw-r--r--. 1 root root  627M feb  2 22:22 kairos-core-debian.iso
-rw-r--r--. 1 root root    88 feb  2 22:22 kairos-core-debian.iso.sha256
-rw-r--r--. 1 root root  445M feb  2 22:32 kairos-core-fedora.iso
-rw-r--r--. 1 root root    88 feb  2 22:32 kairos-core-fedora.iso.sha256
-rw-r--r--. 1 root root  925M feb  2 22:24 kairos-core-opensuse-leap.iso
-rw-r--r--. 1 root root    95 feb  2 22:24 kairos-core-opensuse-leap.iso.sha256
-rw-r--r--. 1 root root 1016M feb  2 22:30 kairos-core-opensuse-tumbleweed.iso
-rw-r--r--. 1 root root   101 feb  2 22:30 kairos-core-opensuse-tumbleweed.iso.sha256
-rw-r--r--. 1 root root  392M feb  2 22:47 kairos-core-rockylinux.iso
-rw-r--r--. 1 root root    92 feb  2 22:47 kairos-core-rockylinux.iso.sha256
-rw-r--r--. 1 root root  862M feb  2 22:40 kairos-core-ubuntu-20-lts.iso
-rw-r--r--. 1 root root    95 feb  2 22:40 kairos-core-ubuntu-20-lts.iso.sha256
-rw-r--r--. 1 root root  972M feb  2 22:44 kairos-core-ubuntu-22-lts.iso
-rw-r--r--. 1 root root    95 feb  2 22:44 kairos-core-ubuntu-22-lts.iso.sha256
-rw-r--r--. 1 root root  1,1G feb  2 22:36 kairos-core-ubuntu.iso

Compression:

-rw-r--r--. 1 root root  627M feb  3 09:28 kairos-core-debian.iso
-rw-r--r--. 1 root root    88 feb  3 09:28 kairos-core-debian.iso.sha256
-rw-r--r--. 1 root root  445M feb  3 09:36 kairos-core-fedora.iso
-rw-r--r--. 1 root root    88 feb  3 09:36 kairos-core-fedora.iso.sha256
-rw-r--r--. 1 root root  925M feb  3 09:31 kairos-core-opensuse-leap.iso
-rw-r--r--. 1 root root    95 feb  3 09:31 kairos-core-opensuse-leap.iso.sha256
-rw-r--r--. 1 root root 1016M feb  3 09:34 kairos-core-opensuse-tumbleweed.iso
-rw-r--r--. 1 root root   101 feb  3 09:34 kairos-core-opensuse-tumbleweed.iso.sha256
-rw-r--r--. 1 root root  392M feb  3 09:50 kairos-core-rockylinux.iso
-rw-r--r--. 1 root root    92 feb  3 09:50 kairos-core-rockylinux.iso.sha256
-rw-r--r--. 1 root root  862M feb  3 09:44 kairos-core-ubuntu-20-lts.iso
-rw-r--r--. 1 root root    95 feb  3 09:44 kairos-core-ubuntu-20-lts.iso.sha256
-rw-r--r--. 1 root root  972M feb  3 09:47 kairos-core-ubuntu-22-lts.iso
-rw-r--r--. 1 root root    95 feb  3 09:47 kairos-core-ubuntu-22-lts.iso.sha256
-rw-r--r--. 1 root root  1,1G feb  3 09:40 kairos-core-ubuntu.iso
-rw-r--r--. 1 root root    88 feb  3 09:40 kairos-core-ubuntu.iso.sha256

@Itxaka
Copy link
Member Author

Itxaka commented Feb 3, 2023

No compression timing (17 seconds):

+iso | DEBU[2023-02-02T21:29:42Z] Running cmd: 'mksquashfs /tmp/elemental-iso715094356/rootfs /tmp/elemental-iso715094356/iso/rootfs.squashfs -b 1024k' 
+iso | INFO[2023-02-02T21:29:59Z] Creating EFI image...

Compression timing (1 minute):

+iso | DEBU[2023-02-03T08:39:19Z] Running cmd: 'mksquashfs /tmp/elemental-iso033794531/rootfs /tmp/elemental-iso033794531/iso/rootfs.squashfs -b 1024k -comp gzip' 
+iso | INFO[2023-02-03T08:40:20Z] Creating EFI image... 

Copy link
Member

@mudler mudler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! nais!

@mudler mudler merged commit 4dabf47 into kairos-io:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants