🤖 Don't run installation twice on installation tests #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kairos-io canceled.
|
|
@paynejacob good catch for the issue, just splitting this here to see if fixes tests, I'm fine with the lock in #809 - I just wanted to fix the test suite here. |
Itxaka
previously approved these changes
Feb 3, 2023
oz123
previously approved these changes
Feb 3, 2023
Signed-off-by: mudler <mudler@c3os.io>
Itxaka
previously approved these changes
Feb 3, 2023
Signed-off-by: mudler <mudler@c3os.io>
|
need another review, discovered a bug while mutating tests =) |
Itxaka
previously approved these changes
Feb 3, 2023
Signed-off-by: mudler <mudler@c3os.io>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mudler mudler@c3os.io
What this PR does / why we need it: Attempt to fix #781 by making the test explicit. we do run the install manually, so no need to specify automatic installation in the cloud configs. That is tested by autoinstall tests (https://github.com/kairos-io/kairos/blob/master/tests/assets/autoinstall.yaml)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #781