-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ custom user bind and ephemeral mounts #692
Conversation
✅ Deploy Preview for kairos-io canceled.
|
This is now working. However, the tests are not complete yet, and docs are needed. |
559619a
to
972e21c
Compare
972e21c
to
4ad6367
Compare
333a33f
to
4abe644
Compare
4abe644
to
f488b34
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #692 +/- ##
=======================================
Coverage 19.57% 19.57%
=======================================
Files 18 18
Lines 1446 1446
=======================================
Hits 283 283
Misses 1114 1114
Partials 49 49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9979a69
to
1dcce77
Compare
f4a14fd
to
30eac03
Compare
30eac03
to
3252b3c
Compare
@mudler seems that was because I added earthlyignore file. I took this commit out, this is now handled in #794 . |
Users can now specify custom and ephemeral mounts in cloud-init under the `install` section, e.g.: ``` users: - name: kairos ... install: auto: true device: "auto" bind_mounts: - /mnt/bind1 - /mnt/bind2 ephemeral_mounts: - /mnt/ephemeral - /mnt/ephemeral2 ... ``` Ephemeral mounts are mounted as RW - but changes are discarded when the machine is restart. Bind mounts will persist changes after restarted. This is a fix for #210 Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
DRY the code, change how we call the function install_test Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
We repeat this a more than twice so just extract to own target... Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
This is not needed here. Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Helps deal with space running out in the CI. Signed-off-by: Oz Tiram <oz@spectrocloud.com>
Signed-off-by: Oz Tiram <oz@spectrocloud.com>
3252b3c
to
8037c7e
Compare
* ✨ custom user bind and ephemeral mounts Users can now specify custom and ephemeral mounts in cloud-init under the `install` section, e.g.: ``` users: - name: kairos ... install: auto: true device: "auto" bind_mounts: - /mnt/bind1 - /mnt/bind2 ephemeral_mounts: - /mnt/ephemeral - /mnt/ephemeral2 ... ``` Ephemeral mounts are mounted as RW - but changes are discarded when the machine is restart. Bind mounts will persist changes after restarted. This is a fix for #210 Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Add the custom user mount to /cos/run/cos-layout.env Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Add docs for custom user mounts in configuration example Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Reuse test_install function DRY the code, change how we call the function install_test Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Enable custom mount tests and install tests Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Enable tests in CI Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Remove duplicate if check Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Remove uneeded fmt.Println ... Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Use separate label for custom mounts Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Earthfile - DRY ginkgo We repeat this a more than twice so just extract to own target... Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Correct return type for ContainElements Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Remove CLOUD_INIT from custom mounts test This is not needed here. Signed-off-by: Oz Tiram <oz@spectrocloud.com> * Fix qemu-test-* earthly targets Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 Fix CPU passing to VM Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 🔧 remove apt cache after install qemu Helps deal with space running out in the CI. Signed-off-by: Oz Tiram <oz@spectrocloud.com> * 📖 Document custom mounts Signed-off-by: Oz Tiram <oz@spectrocloud.com> --------- Signed-off-by: Oz Tiram <oz@spectrocloud.com> Co-authored-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
Users can now specify custom and ephemeral mounts in cloud-init under the
install
section, e.g.:Ephemeral mounts are mounted as RW - but changes are discarded when the machine is restart.
Bind mounts will persist changes after restarted.
This is a fix for #210
Signed-off-by: Oz Tiram oz@spectrocloud.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #