Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use envsubst for live-overlay.yaml #662

Merged
merged 4 commits into from
Jan 19, 2023

Conversation

mauromorales
Copy link
Member

Signed-off-by: Mauro Morales mauro.morales@spectrocloud.com

What this PR does / why we need it:

Just to make the Earthfile a bit easier to read and maintain

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@netlify
Copy link

netlify bot commented Jan 17, 2023

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit b6b23f5
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/63c7cc2b584308000839b6be

@mauromorales mauromorales requested a review from a team January 17, 2023 15:27
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! More lines of code removed in a PR than added ;-) always good

Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mudler
Copy link
Member

mudler commented Jan 19, 2023

fails on bundles tests. #675

@mudler mudler merged commit b2f28bc into master Jan 19, 2023
@mudler mudler deleted the chore-use-envsubst-for-live-overlay branch January 19, 2023 11:01
oz123 pushed a commit that referenced this pull request Jan 25, 2023
Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants