Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Do not run kcrypt hook without a oem mount #368

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

mudler
Copy link
Member

@mudler mudler commented Nov 3, 2022

What this PR does / why we need it: It runs the hook only if there is a OEM partition accessible. It uses the state api to get the state and the device name programmatically

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #358

Signed-off-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Nov 3, 2022

Deploy Preview for kairos-io canceled.

Name Link
🔨 Latest commit 9357d5a
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/6363968fee259b0009862995

@mudler mudler requested a review from a team November 3, 2022 10:23
@@ -2,10 +2,11 @@ name: "Update discovery plugins"
stages:
after-upgrade:
- name: "Update plugins"
if: "[ $(kairos-agent state get oem.found) == 'true' ]"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this actually gates the block if there is no oem partition found (ARM, for instance)

@mudler mudler merged commit f495946 into master Nov 3, 2022
@mudler mudler deleted the fixup/kcrypt branch November 3, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kcrypt hook fails on ARM
1 participant