Fixing the interface names across OS flavors #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added net.ifnames=1 to kernel params. Signed-off-by: vipsharm <sharma.vipin@gmail.com>
✅ Deploy Preview for kairos-io canceled.
|
paynejacob
previously approved these changes
Oct 3, 2022
| set kernelcmd="console=tty1 root=live:CDLABEL=$recoverylabel rd.live.dir=/ rd.live.squashimg=$img panic=5" | ||
| else | ||
| # Boot arguments when the image is used as active/passive | ||
| set kernelcmd="console=tty1 root=LABEL=$label net.ifnames=1 iso-scan/filename=$img panic=5 security=selinux rd.cos.oemlabel=COS_OEM selinux=1" |
There was a problem hiding this comment.
were these se linux args already there?
There was a problem hiding this comment.
I copied the default elemental bootargs.cfg from documentation and added net.ifnames=1
Default values copied from here
https://rancher.github.io/elemental-toolkit/docs/customizing/configure_grub/
Signed-off-by: vipsharm <sharma.vipin@gmail.com>
mudler
approved these changes
Oct 3, 2022
mudler
added a commit
that referenced
this pull request
Oct 20, 2022
Use cos initrd module by default
mudler
added a commit
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added net.ifnames=1 to kernel params.
Signed-off-by: vipsharm sharma.vipin@gmail.com