Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Subject prefix filtering support #525

Merged

Conversation

ludovic-boutros
Copy link
Contributor

@ludovic-boutros ludovic-boutros commented Aug 10, 2022

  • Please check if the PR fulfills these requirements
  • The commit messages are descriptive
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • An issue has been created for the pull requests. Some issues might require previous discussion.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR introduce the support of subject prefix filtering.

  • What is the current behavior? (You can also link to an open issue here)
    Currently it is not possible to define which subjects should be managed.

  • What is the new behavior (if this is a feature change)?
    As we can do with topics and groups, with this PR, we can now manage which subjects should be managed using prefixes.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

Fix #526.

Sorry, something went wrong.

@ludovic-boutros ludovic-boutros changed the title Add Subject prefix filtering support WIP: Add Subject prefix filtering support Aug 11, 2022
@ludovic-boutros
Copy link
Contributor Author

Some tests do not pass. Currently looking for why.
@purbon are some integration tests a bit flacky when running multiple times ?
This could be because some bindings or ressources in general could stay in the integration cluster ?

@ludovic-boutros
Copy link
Contributor Author

ludovic-boutros commented Aug 11, 2022

@purbon I think I have found a bug.
When a prefix is defined (topic, group or now subject), cluster bindings are filtered.

@ludovic-boutros ludovic-boutros changed the title WIP: Add Subject prefix filtering support Add Subject prefix filtering support Aug 11, 2022
@purbon
Copy link
Collaborator

purbon commented Aug 14, 2022

Thanks a lot for your contributions @ludovic-boutros and team, I'm currently on holidays, but I promise to take them in as soon as possible.

@purbon
Copy link
Collaborator

purbon commented Aug 22, 2022

Back from my break, thanks a lot for your help in the project again! ❤️

@purbon purbon self-requested a review August 22, 2022 09:32
@purbon purbon merged commit 78b90c7 into kafka-ops:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add subject filtering support
2 participants