tests: txlogsCompactionTest stops the node during compaction #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundnoble
added a commit
that referenced
this pull request
Apr 10, 2024
Change-Id: I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431 Github PR: #1902
edmundnoble
force-pushed
the
I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
branch
2 times, most recently
from
6e542d6 to
bf1fac0
Compare
edmundnoble
added a commit
that referenced
this pull request
Apr 10, 2024
Github PR: #1902 Change-Id: I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
edmundnoble
added a commit
that referenced
this pull request
Apr 10, 2024
txlogsCompactionTest is somehow observing the pre-compaction state when it looks at the txlogs sometimes, this is supposed to fix that. It also makes our utils for running nodes take their database dirs as parameters instead of having those utils generate them. Github PR: #1902 Change-Id: I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
edmundnoble
force-pushed
the
I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
branch
from
bf1fac0 to
ad29091
Compare
edmundnoble
added a commit
that referenced
this pull request
Apr 10, 2024
txlogsCompactionTest is somehow observing the pre-compaction state when it looks at the txlogs sometimes, this is supposed to fix that. It also makes our utils for running nodes take their database dirs as parameters instead of having those utils generate them. Github PR: #1902 Change-Id: I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
edmundnoble
force-pushed
the
I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
branch
from
ad29091 to
54cb708
Compare
edmundnoble
added a commit
that referenced
this pull request
Apr 10, 2024
txlogsCompactionTest is somehow observing the pre-compaction state when it looks at the txlogs sometimes, this is supposed to fix that. It also makes our utils for running nodes take their database dirs as parameters instead of having those utils generate them. Github PR: #1902 Change-Id: I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
edmundnoble
force-pushed
the
I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
branch
from
54cb708 to
700e5df
Compare
chessai
previously approved these changes
Apr 11, 2024
txlogsCompactionTest is somehow observing the pre-compaction state when it looks at the txlogs sometimes, this is supposed to fix that. It also makes our utils for running nodes take their database dirs as parameters instead of having those utils generate them. Github PR: #1902 Change-Id: I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
edmundnoble
force-pushed
the
I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431
branch
from
700e5df to
c7a0822
Compare
thoughtpolice
approved these changes
Apr 19, 2024
thoughtpolice
approved these changes
Apr 23, 2024
ghost
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
txlogsCompactionTest is somehow observing the pre-compaction
state when it looks at the txlogs sometimes, this is supposed
to fix that. It also makes our utils for running nodes take
their database dirs as parameters instead of having those utils
generate them.
https://gerrit.aseipp.dev/q/I6bd1aeec174836d12e753eb8e1b6cacbcb8ed431