pact-import tool: set an environment variable and add more docs. #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chessai
commented
Feb 14, 2024
chessai
commented
- set SNAPSHOT_BLOCKHEIGHT env var. This is so tools such as pact-diff can consume the blockheight.
- print BlockHeight in logs when hashes do or do not align
- expand user-facing help text
- add module-level documentation
- delete commented-out code block
chessai
force-pushed
the
chessai/pact-import-set-env
branch
from
b0f69b4 to
e1f7ad6
Compare
…lp text; add module-level documentation; delete commented-out code block; Change-Id: Iac45bc0614cdc8cd4e98796772f09d7f0c580776
chessai
force-pushed
the
chessai/pact-import-set-env
branch
from
e1f7ad6 to
c344553
Compare
thoughtpolice
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.