Allow the node to communicate when it's ready to serve requests #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundnoble
force-pushed
the
push-umszsnnrulxl
branch
6 times, most recently
from
245a5a1 to
00177c2
Compare
edmundnoble
force-pushed
the
push-umszsnnrulxl
branch
from
00177c2 to
38c6412
Compare
chessai
approved these changes
Feb 9, 2024
| -> MVar (PeerInfo, Port) | ||
| -> ChainwebConfiguration | ||
| -> FilePath | ||
| -- ^ pact db dir | ||
| -> FilePath | ||
| -- ^ rocksdb dir | ||
| -- ^ dir for db backups |
There was a problem hiding this comment.
nice, that makes this more clear
edmundnoble
force-pushed
the
push-umszsnnrulxl
branch
2 times, most recently
from
920bd67 to
38c6412
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at fixing the racy issue that's causing
RemotePactTestto be flaky. I ran into a segfault while I was writing this, which was caused by closing the rocksdb while the node was still running, in turn caused by incorrect use ofasync.