Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pact import tool #1792

Merged
merged 110 commits into from
Feb 6, 2024
Merged

pact import tool #1792

merged 110 commits into from
Feb 6, 2024

Conversation

chessai
Copy link
Contributor

@chessai chessai commented Dec 13, 2023 •
edited
Loading

chessai and others added 20 commits December 1, 2023 17:11
@chessai
hash
d47008d
@chessai
wip
875e52e
@chessai
tool is written
26b3bc2
@chessai
test hashes library as alternative to crypton
bc0aeda
@larskuhtz @chessai
support dynamic loading of sqlite3 sha3 extension
84be948
@chessai
add a shellHook to build the sqlite extension. add gdb, sqlite, and j…
ca00a58 
…q to the shell buildInputs
@chessai
get active state at a particular blockheight, compute hashes there too
74428dd
@chessai
remove don'tdropnewtables flag
81f359b
@chessai
compaction: rip out grand hashing. measure time and log time for ever…
ac298f1 
…y query.
@chessai
fix typo
54296dc
@chessai
add a moment in time of the grandHash stuff, about to rip a lot of th…
5fb7150 
…ings out
@chessai
remove all compaction comparisons to reference implementation
63f115c
@chessai
correctly and safely drop from TransactionIndex
9a4d793
@chessai
remote C.GrandHash config from bench and test
b8d2f94
@chessai
expose readHighestCutHeaders from Chainweb.CutDB
dbf5352
@chessai
pact-calc and pact-import
325665f
@chessai
three phases, not two, in computeGrandHashes; switch to toAscList for…
45ef992 
… JSON encoding of inner map
@chessai
fix bug in pact-import tool and document more of the source
bae603c
@chessai
embed hashes into library
542a351
@chessai
fix encoding of BlockHeaders to EmbeddedHashes.hs
6917ee4
@chessai chessai marked this pull request as draft December 13, 2023 21:17
thoughtpolice
thoughtpolice reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all mostly pretty small comments; I deleted a few readability ones so they aren't distracting but did still leave a couple. Feel free to skip them if you want.

bench/Chainweb/Pact/Backend/ForkingBench.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/Compaction.hs
\ ( tablename TEXT NOT NULL \
\ , rowkey TEXT NOT NULL \
\ , vrowid INTEGER NOT NULL \
\ , UNIQUE (tablename,rowkey) ); "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I don't think we can change this now, but FWIW compound PRIMARY KEY (tablename, rowkey) works just fine too; I think unfortunately you can't change or add a PRIMARY KEY after table creation, but just a note for the future, maybe.

src/Chainweb/Pact/Backend/PactState/Diff.hs Show resolved Hide resolved
src/Chainweb/Pact/Backend/PactState/GrandHash/Algorithm.hs Outdated Show resolved Hide resolved
src/Chainweb/Pact/Backend/PactState/GrandHash/Calc.hs Show resolved Hide resolved
test/Chainweb/Test/MultiNode.hs Outdated Show resolved Hide resolved
test/Chainweb/Test/MultiNode.hs Show resolved Hide resolved
@chessai chessai enabled auto-merge February 6, 2024 18:54
@chessai chessai added this pull request to the merge queue Feb 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2024
@chessai chessai added this pull request to the merge queue Feb 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2024
@chessai chessai added this pull request to the merge queue Feb 6, 2024
Merged via the queue into master with commit de883de Feb 6, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice left review comments

@edmundnoble edmundnoble edmundnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chessai @thoughtpolice @edmundnoble @larskuhtz