Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webauthn jwk formats #1779

Merged
merged 48 commits into from
Nov 23, 2023
Merged

Webauthn jwk formats #1779

merged 48 commits into from
Nov 23, 2023

Conversation

edmundnoble
Copy link
Contributor

@edmundnoble edmundnoble commented Nov 13, 2023 •
edited by imalsogreg
Loading

Still to do:

  • fork tests of webauthn keys + sigs
  • fork new sig format
  • fix rosetta or determine if we need to
  • partial replay at the minimum from when webauthn signatures became valid on mainnet

@imalsogreg imalsogreg force-pushed the mlep/webauthn-jwk-formats branch from 77cd9ed to 630c022 Compare November 13, 2023 17:43
@imalsogreg imalsogreg force-pushed the mlep/webauthn-jwk-formats branch from 4da99c4 to 77517a8 Compare November 20, 2023 23:25
@imalsogreg imalsogreg force-pushed the mlep/webauthn-jwk-formats branch from e7adbbc to 6bc9c05 Compare November 21, 2023 20:02
emilypi
emilypi reviewed Nov 22, 2023
View reviewed changes
bench/Chainweb/Pact/Backend/ForkingBench.hs Show resolved Hide resolved
src/Chainweb/Pact/RestAPI/Server.hs Show resolved Hide resolved
src/Chainweb/Rosetta/Utils.hs Show resolved Hide resolved
tools/ea/Ea.hs Show resolved Hide resolved
src/Chainweb/Pact/TransactionExec.hs Show resolved Hide resolved
imalsogreg and others added 22 commits November 22, 2023 12:58
@imalsogreg imalsogreg force-pushed the mlep/webauthn-jwk-formats branch from d2db604 to cb44233 Compare November 22, 2023 20:58
emilypi
emilypi approved these changes Nov 22, 2023
View reviewed changes
src/Chainweb/Transaction.hs Outdated Show resolved Hide resolved
@imalsogreg imalsogreg enabled auto-merge November 22, 2023 21:03
edmundnoble
edmundnoble commented Nov 22, 2023
View reviewed changes
src/Chainweb/Rosetta/RestAPI/Server.hs Outdated
Comment on lines 353 to 354
cid <- annotate rosettaError' (validateNetwork v net)
void $ annotate rosettaError' (validateNetwork v net)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the void $ ... anymore.

jmcardon
jmcardon reviewed Nov 23, 2023
View reviewed changes
test/pact/contTXOUTNew.pact
, "meta": {}
, "req-key": "rwFh_qoxumclpxZj6QIo5GOM0CmE5AztlKukhFCRTVA"
, "req-key": "pHsX8RJkJNRlrGflD_vRiKOsjlLSVGdf1hYU_eI6fgU"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these req keys and logs changed because we added NetworkId to the command.

jmcardon
jmcardon reviewed Nov 23, 2023
View reviewed changes
test/golden/transfer-accounts-expected.txt
@@ -3,4 +3,4 @@
- cmd:
contents: (test1.transfer "Acct1" "Acct2" 1.00)
tag: Code
output: noxWe0aOpl3J20QHMVJP8EvPGG8kftv63GeIjvJwrXQ
output: O4tU1VdTniyZH8CkVPKViCvHT6C_lke6lmObZeKjPL8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here, no red flags, just networkId difference.

edmundnoble and others added 4 commits November 23, 2023 15:57
@edmundnoble
Delete commented line
e9f12e5 
Co-authored-by: Jose <jose@kadena.io>
@edmundnoble
Amend test name
307f65d 
Co-authored-by: Jose Cardona <jose@kadena.io>
@edmundnoble
Fix fork heights
c189ba5 
Co-authored-by: Jose <jose@kadena.io>
@edmundnoble
Delete unnecessary do and network validation
5636010 
Co-authored-by: Jose <jose@kadena.io>
@edmundnoble edmundnoble force-pushed the mlep/webauthn-jwk-formats branch from 3ce1f0b to 5636010 Compare November 23, 2023 21:07
@edmundnoble
Inline validPubKey
affe2fe 
Co-authored-by: Jose <jose@kadena.io>
@imalsogreg imalsogreg added this pull request to the merge queue Nov 23, 2023
@edmundnoble edmundnoble removed this pull request from the merge queue due to a manual request Nov 23, 2023
@edmundnoble
Address feedback
a204616 
Co-authored-by: Jose <jose@kadena.io>
@edmundnoble edmundnoble added this pull request to the merge queue Nov 23, 2023
Merged via the queue into master with commit 8d05f74 Nov 23, 2023
38 of 39 checks passed
@edmundnoble edmundnoble deleted the mlep/webauthn-jwk-formats branch February 6, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imalsogreg imalsogreg imalsogreg left review comments

@jwiegley jwiegley jwiegley left review comments

@jmcardon jmcardon jmcardon approved these changes

@emilypi emilypi emilypi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@edmundnoble @jwiegley @imalsogreg @emilypi @jmcardon @rsoeldner