Fix execValidateBlock #1740
Merged
Fix execValidateBlock #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Sep 22, 2023
•
ghost
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1205566925523368
ghost
force-pushed
the
fix-validate-block
branch
from
40a3ac4 to
2eaf1de
Compare
ghost
marked this pull request as ready for review
ghost
force-pushed
the
fix-validate-block
branch
2 times, most recently
from
d69c72e to
dc1ac4b
Compare
edmundnoble
approved these changes
Oct 2, 2023
ghost
force-pushed
the
fix-validate-block
branch
from
dc1ac4b to
ea1efdd
Compare
edmundnoble
requested changes
Oct 13, 2023
src/Chainweb/Payload/PayloadStore.hs
Outdated
| , _payloadWithOutputsTransactionsHash = txsHash | ||
| , _payloadWithOutputsOutputsHash = outsHash | ||
| } | ||
| return $ newPayloadWithOutputs (_blockMinerData txs) (_blockCoinbaseOutput outs) (V.zip (_blockTransactions txs) (_blockOutputs outs)) |
There was a problem hiding this comment.
So we're recomputing the hashes now? Can we avoid that?
There was a problem hiding this comment.
Yep, by using the neighbour smart constructor payloadWithOutputs.
tools/cwtool/TxSimulator.hs
Outdated
| @@ -108,7 +108,9 @@ simulate sc@(SimConfig dbDir txIdx' _ _ cid ver gasLog doTypecheck) = do | |||
| (_cpBeginCheckpointerBatch cp) | |||
| (_cpDiscardCheckpointerBatch cp) $ case (txIdx',doTypecheck) of | |||
| (Just txIdx,_) -> do -- single-tx simulation | |||
| let PayloadWithOutputs txs md _ _ _ _ :: PayloadWithOutputs = head pwos | |||
| let pwo :: PayloadWithOutputs = head pwos | |||
There was a problem hiding this comment.
Idk why this type annotation is here.
ghost
force-pushed
the
fix-validate-block
branch
from
32ff584 to
8968cb9
Compare
|
@edmundnoble can we merge this one as well? |
edmundnoble
approved these changes
Oct 19, 2023
ghost
force-pushed
the
fix-validate-block
branch
from
8968cb9 to
fddafd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.