Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved support of XIBs for cells #169

Merged
merged 3 commits into from
May 31, 2016
Merged

Improved support of XIBs for cells #169

merged 3 commits into from
May 31, 2016

Conversation

kettch
Copy link
Contributor

@kettch kettch commented May 30, 2016

  • contentView can be created and linked as an outlet
  • cell is created correctly from the XIB (through initWithCoder:)

kettch added 2 commits May 30, 2016 10:51
@kettch
Improving behavior when using XIBs for cells (contentView can be decl…
a462512 
…ared in XIB, and cell is configured correctly when init'd with coder)
@kettch
Fixed indentation
6a74231
@jwilling
Copy link
Owner

jwilling commented May 31, 2016 •
edited
Loading

Thanks for catching this! Since the initialization is (nearly) the same as in -initWithFrame:, is there any chance you could move this into a static common initializer function which is called in both -initWithFrame: and -initWithCoder:? For what it's worth, I prefer your version of passing nil to to -addSubview:positioned:relativeTo:. 👾

@kettch
Copy link
Contributor Author

kettch commented May 31, 2016

Well, since I was the one who pushed the registerXib in the first place, that's only fair ;)
Just pushed the change!

@jwilling
Copy link
Owner

Fantastic, thanks again for your excellent contributions! :octocat:

@jwilling jwilling merged commit 6d927c9 into jwilling:master May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kettch @jwilling