Do not pass up mouse actions on cell for Issue #166 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now the cell forwarded mouse down/up events that it handled to the super implementation. This means that the events are forwarded to the parent views underneath the cell. This patch removes the super calls. The cell is handling the calls and should not forward the actions to the view underneath. This allows to differentiate between clicks on a cell and clicks in non-cell space.
|
Thank you for putting this together! 📦 I apologize for the delay in responding to this. I agree with this change, but I am slightly worried about backwards compatibility for people who were depending on this behavior. I suppose my best option is just to add a new tag for this commit, which I will do. This will be tagged as 1.6. Thanks again. Fixes #166. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now the cell forwarded mouse down/up events that it handled to
the super implementation. This means that the events are forwarded to
the parent views underneath the cell.
This patch removes the super calls. The cell is handling the calls and
should not forward the actions to the view underneath.
This allows to differentiate between clicks on a cell and clicks in
non-cell space.