Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround the Chromium bug with navigator.language #17094

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

krassowski
Copy link
Member

References

Fixes #17079

Code changes

Ignore anything after and including @ in navigator.language.

User-facing changes

None

Backwards-incompatible changes

None

@krassowski krassowski added this to the 4.3.x milestone Dec 17, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@jtpio jtpio merged commit 5ee305f into jupyterlab:main Dec 18, 2024
85 of 86 checks passed
@jtpio
Copy link
Member

jtpio commented Dec 18, 2024

@meeseeksdev please backport to 4.3.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Dec 18, 2024
@krassowski krassowski deleted the fix-for-chrome-bug branch December 18, 2024 12:20
krassowski added a commit that referenced this pull request Dec 18, 2024
…age` (#17100)

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
ImpSy pushed a commit to spotinst/jupyterlab that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downstream browser check tests are failing since 4.3.3 release
2 participants