-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terminal performs grep operations based on UI width #16956
Comments
Is the environment variables I think this is due to https://github.com/jupyter/terminado/blob/main/terminado/management.py#L210 - not sure if setting the |
Thanks for opening this issue @satra! Do you happen to have any browser extensions enabled? I tried this myself in Arc and Firefox but I was not able to reproduce this in either but I may not be be accurately following the reproduction steps. Maybe attaching a video would also be helpful to make sure we are attempting to reproduce correctly. |
i think this perhaps demonstrates the phenomena and relates to @holzman 's comment. jovyan@jupyter-satra:~$ ps aux | grep jupyter
jovyan 296 0.0 0.0 6480 2360 pts/2 S+ 03:27 0:00 grep jupyter
jovyan@jupyter-satra:~$ COLUMNS= ps aux | grep jupyter
jovyan 7 0.1 0.0 542636 151464 ? Sl 02:56 0:02 /opt/conda/bin/python3.11 /opt/conda/bin/jupyterhub-singleuser --ip=0.0.0.0 --allow-root
jovyan 298 0.0 0.0 6480 2324 pts/2 S+ 03:27 0:00 grep jupyter
jovyan@jupyter-satra:~$ COLUMNS=20 ps aux | grep jupyter
jovyan 301 0.0 0.0 6480 2320 pts/2 S+ 04:47 0:00 grep jupyter
jovyan@jupyter-satra:~$ COLUMNS=200 ps aux | grep jupyter
jovyan 7 0.0 0.0 618432 151624 ? Sl 02:56 0:03 /opt/conda/bin/python3.11 /opt/conda/bin/jupyterhub-singleuser --ip=0.0.0.0 --allow-root
jovyan 303 0.0 0.0 6480 2320 pts/2 S+ 04:47 0:00 grep jupyter
jovyan@jupyter-satra:~$ ``` |
To remedy this problem option to disable changing the columns to more than available width of the viewport in terminal extension can be introduced. @satra would you say this would be helpful? |
Such an option might need to be implemented in https://github.com/jupyter-server/jupyter_server_terminals and threaded down https://github.com/jupyter/terminado |
Description
as seen above the same command gives two different outputs the difference is the width of the
Reproduce
Expected behavior
shell commands should not be dependent on width of terminal
Context
The text was updated successfully, but these errors were encountered: