-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y][Violation][1.4.3 Contrast (Minimum)] File browser "New" button contrast does not meet WCAG 2.2 requirements #16888
Comments
Might be good to check the same elements using JupyterLab's high contrast theme, which is specifically intended for users who need higher contrast than the default theme offers. Do you still see the problems in that case? Also, we might want to update the JupyterLab accessibility statement to mention contrast, because we've had questions like this come up before. |
Retitled this to cover only sub-issue 1, about the "New" (+) button in the file browser. |
@krassowski I think you had the foreground and backgroud switched. Can you double check? when I check with that I get a different value |
I used a color picker which might have been slightly off but my point is that 4.18 in your report does not agree with what I see:
Since 4.6 is greater than 4.5 which is the WCAG AA minimum requirements for text of size 12px and weight of 400. |
This does not matter because the contrast calculations in WCAG 2.x are not very clever and do not account for the difference between background and foreground at all (which bites Jupyter which uses a beautiful orange background but some folks came and changed perfectly readable white text to unreadable black to satisfy arbitrary rules of WCAG 2 contrast checkers, see jupyter/jupyter.github.io#587 - this is only getting fixed in WCAG 3 with APCA) |
Using another color picker I again arrive at |
Thanks. Yes, that may be the reason here. I will confirm soon. |
I see what happened with the contrast checker that you used. It indeed blindly extracted the Since 4.19 is very close to 4.18 that you reported I think this is what happened. I think this is not a real issue then. |
I agree with you. I will close this for now. Thank you for the investigation. |
Adding the response from the tools team here for reference.
|
Thanks @tombrunet, this confirms my guess from #16888 (comment) then. Indeed it could be an issue, but it's only this single button which has blue background (the rule targets it via command id) so it is guaranteed to have a white icon rather than any text. |
Description
I am running an accessibility test suite with Jupyter using the IBM Equal Access Accessibility Checker tool on Chrome browser. The results look good overall, only a few things are missing to reach a first formal level of compliance. So kindly help look into these.
Issues reported were violating WCAG 2.2 requirements.
Ref: https://www.ibm.com/able/requirements/checker-rule-sets
Listing of violations categorized based on the checkpoints.
Full report (includes information on element locations where issue were found):
Accessibility_Report-Untitled.ipynb - JupyterLab.xlsx
Category:
1.4.3 Contrast (Minimum)
Ref: https://www.ibm.com/able/requirements/requirements/?version=v7_3#1_4_3
Violation of Rule:
text_contrast_sufficient
Reproduce
notebook
file to edit.Violation
s reported.Here is the screenshot of the UI scanned for the attached report:
Expected behavior
No violations are reported on the scanning to reach a first formal level of compliance.
Context
The text was updated successfully, but these errors were encountered: