Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching from full to defer windowing mode causes cells out of viewport to disappear #16677

Open
Nagidrop opened this issue Aug 14, 2024 · 3 comments
Open

Switching from full to defer windowing mode causes cells out of viewport to disappear #16677

Nagidrop opened this issue Aug 14, 2024 · 3 comments
Labels
bug

Comments

@Nagidrop
Copy link
Contributor

Description

When you open a notebook (that is longer than viewport) in full windowing mode and then switch to defer, out-of-viewport cells disappear. Cells won't re-appear unless you reopen the notebook. Here is a video demonstrating the problem:

Cells_disappear.mp4

It should be noted that switching from defer to full windowing mode doesn't cause this problem.

Reproduce

  1. Using full windowing mode
  2. Open a notebook with length exceeding view port size
  3. Switch to defer
  4. Cells out of viewport now disappear

Expected behavior

All cells remain after switching from full to defer windowing mode.

Context

  • Operating System and version: Windows 11
  • Browser and version: JupyterLab Desktop 4.2.1-1 (latest)
  • JupyterLab version: 4.2.4 (latest)
@Nagidrop Nagidrop added the bug label Aug 14, 2024
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Aug 14, 2024
@firai
Copy link
Contributor

firai commented Aug 14, 2024

I understand that the defer option behaves properly if JL is opened with this option already selected. I'm wondering if the note below the setting just needs to ask the user to refresh the page after changing this setting to defer.

@krassowski
Copy link
Member

We have some settings that show up a dialog with "Refresh" dialog (I think changes to toolbars do that?). Ideally the logic would be fixed so that changing modes on the fly is not the issue but if this is substantial effort having a dialog with "Refresh" button might be an improvement worth merging.

@Nagidrop
Copy link
Contributor Author

I think the fix won't be too complicated because after switching from full to defer, switching back to full does make all the cells visible again. But I'm not familiar with JupyterLab's codebase so I'd leave it for the contributors to evaluate.

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Aug 20, 2024
@JasonWeill JasonWeill mentioned this issue Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@firai @krassowski @Nagidrop @JasonWeill