Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restyle or remove boxes around options in settings editor #16561

Open
JasonWeill opened this issue Jul 8, 2024 · 2 comments
Open

Restyle or remove boxes around options in settings editor #16561

JasonWeill opened this issue Jul 8, 2024 · 2 comments
Labels
enhancement pkg:settingeditor status:Needs Design

Comments

@JasonWeill
Copy link
Contributor

This is a follow-on to #14375. After this change, the boxes around certain options now have borders that look confusingly similar to the divider between the left panel of the settings widget and the main area. On macOS, the narrow scroll bar track has a slight gray coloring, but we should lighten or delete the box borders indicated by the arrow below.

image
@JasonWeill JasonWeill added enhancement pkg:settingeditor status:Needs Triage Applied to new issues that need triage labels Jul 8, 2024
@JasonWeill JasonWeill mentioned this issue Jul 8, 2024
Merged
@JasonWeill
Copy link
Contributor Author

Additional settings issues noted by @andrii-i in #14375 (comment):

@JasonWeill JasonWeill added status:Needs Design and removed status:Needs Triage Applied to new issues that need triage labels Jul 9, 2024
@JasonWeill JasonWeill mentioned this issue Jul 9, 2024
Open
@krassowski
Copy link
Member

On the other hand, when objects are not grouped with this border then users frequently mistake to which section the inputs belong, see jupyterlab/jupyter-ai#889 (comment) - I saw this exact issue in a couple of different reports.

Of note if the color of the bar on the left was grey we would not have this issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement pkg:settingeditor status:Needs Design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krassowski @JasonWeill