Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PR username when no CircleCI project #531

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Use PR username when no CircleCI project #531

merged 1 commit into from
Mar 11, 2020

Conversation

GeorgianaElena
Copy link
Member

  1. When implementing Update tests #511, I didn't realize that when a TLJH fork doesn't have CircleCI setup there's no CIRCLE_PROJECT_USERNAME env var. Instead there is a CIRCLE_PR_USERNAME that can be used.

Example:

  • My TLJH fork has CircleCI setup, there are these env vars available:
    project
  • @minrk and @jtpio recent PRs don't have these env vars and instead have:
    min
    jtpio
  1. Another way to solve this issue is installing from git refs (available since pip 10). However this would imply some gymnastics parsing the CIRCLE_PULL_REQUEST var.
    circle_pr
    like this:
index = CIRCLE_PULL_REQUEST.find("/pull/")
BOOTSTRAP_PIP_SPEC="git+" + CIRCLE_PULL_REQUEST[:index] + ".git@ref" + CIRCLE_PULL_REQUEST[index:] + "/head"

So that in the end to have BOOTSTRAP_PIP_SPEC be:
git+https://github.com/jupyterhub/the-littlest-jupyterhub.git@ref/pull/527/head

What do folks think is the better way?

@jtpio
Copy link
Contributor

jtpio commented Mar 9, 2020

Thanks @GeorgianaElena for looking into this 👍

No strong opinion here, but it looks like the current change (option 1) works well and is quite explicit?

@GeorgianaElena GeorgianaElena requested a review from betatim March 10, 2020 12:12
@betatim betatim merged commit c81a0b1 into jupyterhub:master Mar 11, 2020
@betatim
Copy link
Member

betatim commented Mar 11, 2020 •
edited
Loading

Looks good to me, so merged it.

Do you know why the codecov checck was missing/pending?

@GeorgianaElena GeorgianaElena deleted the fix_tests branch June 19, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betatim betatim Awaiting requested review from betatim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgianaElena @jtpio @betatim