Missing breaking change in 5.0.0 changelog: URL tokens #4978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, it was in the forward-port of the security PR for GHSA-7r3h-4ph8-w38g, which touched a lot of things. The PR merge commit is here. The 4.x PR introduced the option, leaving it opt-out to avoid breaking things, while 5.0 opted in to better security by default. Looking back, I probably should have made the toggle in its own PR instead of its own commit for better visibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaking change was missing from the 5.0.0 changelog, because it doesn't seem to be associated with a PR:
b319b58