Enable auto-flushing of output to fix testfeed details mode
#4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sormuras
reviewed
Nov 25, 2024
junit-platform-console/src/main/java/org/junit/platform/console/ConsoleLauncher.java
Show resolved
Hide resolved
sormuras
approved these changes
Nov 25, 2024
|
It crossed my mind, too. 🙂 But then we couldn't encapsulate the properties. |
marcphilipp
added a commit
that referenced
this pull request
Dec 11, 2024
marcphilipp
added a commit
that referenced
this pull request
Dec 11, 2024
Prior to this commit, `ConsoleLauncher` created `PrintWriters` that wouldn't flush automatically when `println` is called which stopped the `testfeed` details mode from being useful. Moreover, it didn't initialized them with the right `Charsets`. Now, we rely on Picocli's initialization again which does both correctly. (cherry picked from commit b8b5dc4)
marcphilipp
added a commit
that referenced
this pull request
Dec 11, 2024
(cherry picked from commit d7e765c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Prior to this PR,
ConsoleLaunchercreatedPrintWritersthat wouldn't flush automatically whenprintlnis called which stopped thetestfeeddetails mode from being useful. Moreover, it didn't initialized them with the rightCharsets. Now, we rely on Picocli's initialization again which does both correctly.Definition of Done
@APIannotations